refactor(ButtonBase): update selector to have specificty 0,1,0 #5584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c78eae4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Jan 21, 2025
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358837 |
|
🔴 golden-jobs completed with status |
github-actions
bot
added
integration-tests: failing
mperrotti
approved these changes
Jan 22, 2025
Contributor
mperrotti
left a comment
mperrotti
left a comment
There was a problem hiding this comment.
Used the preview release to test in primer-docs, and this works as expected 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4703
Changelog
New
Changed
.ButtonBaseto have specificity of at least0,1,0to no longer get overridden by reset styles or equivalent selectors with0,1,0specificityRemoved
Rollout strategy