Skip to content

feat(ConfirmationDialog): Convert ConfirmationDialog to CSS modules behind team feature flag #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 10, 2024
Merged

feat(ConfirmationDialog): Convert ConfirmationDialog to CSS modules behind team feature flag #5331

merged 11 commits into from
Dec 10, 2024

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Nov 25, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4134

Changelog

New

  • Converts ConfirmationDialog to CSS modules behind team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3afa403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 25, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 15:44 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.56 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 103.9 KB (+0.1% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 15:52 Inactive
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 25, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 25, 2024
@primer primer bot temporarily deployed to github-pages November 25, 2024 16:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 16:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 16:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 18:48 Inactive
@TylerJDev TylerJDev added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Nov 25, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 25, 2024
@primer primer bot temporarily deployed to github-pages November 25, 2024 20:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 November 25, 2024 20:13 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352653

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@TylerJDev TylerJDev removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 3, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5331 December 3, 2024 00:07 Inactive
@TylerJDev TylerJDev added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 3, 2024
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

TylerJDev
TylerJDev commented Dec 3, 2024
View reviewed changes
packages/react/src/ConfirmationDialog/ConfirmationDialog.tsx
const ConfirmationBody: React.FC<React.PropsWithChildren<DialogProps>> = ({children}) => {
return <StyledConfirmationBody>{children}</StyledConfirmationBody>
const enabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
return <StyledConfirmationBody className={enabled && classes.ConfirmationBody}>{children}</StyledConfirmationBody>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't believe we allow custom styling for this component, I didn't bother adding a className prop. Not sure if we should always add one regardless or not if the component doesn't utilize sx or custom styles?

@TylerJDev TylerJDev marked this pull request as ready for review December 3, 2024 15:04
@TylerJDev TylerJDev requested review from a team as code owners December 3, 2024 15:04
@TylerJDev TylerJDev added this pull request to the merge queue Dec 10, 2024
@TylerJDev TylerJDev added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit e39dddb Dec 10, 2024
43 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/css-modules-confirmation-dialog branch December 10, 2024 17:41
@primer primer bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerJDev @jonrohan