(reverted) SelectPanel: Prepare for non-anchored variants #5230

siddharthkp · 2024-11-05T11:38:21Z

Reverted in Revert "SelectPanel: Prepare for non-anchored variants" #5255

Based on SelectPanel: Implement full variant for narrow screens #5170

Replace AnchoredOverlay with Overlay + useAnchoredPosition to prepare for variants that would skip anchored position

need to check

are integration tests passing?
are the props okay? (were some props going to anchoredoverlay that need to be re-routed)
are the types okay? (same as props)
is the rendered dom the same?
- button is missing tabIndex="0" and id, both of these are okay, as we don't need to do this forwarding anymore
- check if data-has-active-descendant is still correct, it is
is the rendered a11y tree the same
check if footer focus works

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-11-05T11:38:25Z

🦋 Changeset detected

Latest commit: f0be480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-11-05T11:38:56Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2024-11-05T11:41:37Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	98.71 KB (+0.14% 🔺)
packages/react/dist/browser.umd.js	99.13 KB (+0.24% 🔺)

primer-integration · 2024-11-05T12:02:51Z

🔴 golden-jobs completed with status failure.

siddharthkp · 2024-11-07T11:22:52Z

@broccolinisoup Verified everything works well, ready for review

siddharthkp · 2024-11-07T11:25:37Z

packages/react/src/SelectPanel/SelectPanel.tsx

@@ -56,11 +57,6 @@ function isMultiSelectVariant(
  return Array.isArray(selected)
 }

-const focusZoneSettings: Partial<FocusZoneHookSettings> = {
-  // Let FilteredActionList handle focus zone
-  disabled: true,


Note fore reviewer: We no longer need this block, we simply don't add a focusZone now. (we still add focusTrap)

siddharthkp · 2024-11-07T11:25:57Z

packages/react/src/SelectPanel/SelectPanel.tsx

@@ -172,10 +219,13 @@ export function SelectPanel({
    })
  }, [onClose, onSelectedChange, items, selected])

-  const inputRef = React.useRef<HTMLInputElement>(null)


Note for reviewer: inputRef still exists, it's just declared sooner

siddharthkp · 2024-11-07T11:26:39Z

packages/react/src/SelectPanel/SelectPanel.tsx

-  const inputRef = React.useRef<HTMLInputElement>(null)
-  const focusTrapSettings = {
+  /** Focus trap */
+  useFocusTrap({


Note fore reviewer: Adding missing focus trap from AnchoredOverlay. The new keys are passed on what AnchoredOverlay used to do

While it's not possible to Tab out of the filter input to outside the panel, it is possible to Tab to a footer button and then out of the panel, that's why we still need focus trap

broccolinisoup

Looks great! 🎉

primer-integration · 2024-11-08T17:10:30Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350602

This reverts commit dce754b.

…" (#5255)" This reverts commit 64802f1.

) * Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)" (#5255)" This reverts commit 64802f1. * Revert "tiny formatting to make it easier to review" This reverts commit f0be480. * different way of writing the same thing

…" (#5255)" This reverts commit 64802f1.

use Overlay instead of AnchoredOverlay

53ff7ba

siddharthkp self-assigned this Nov 5, 2024

github-actions bot added the staff Author is a staff member label Nov 5, 2024

github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 5, 2024

siddharthkp temporarily deployed to github-pages November 5, 2024 11:40 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5230 November 5, 2024 11:40 Inactive

siddharthkp marked this pull request as ready for review November 7, 2024 11:20

siddharthkp requested a review from a team as a code owner November 7, 2024 11:20

siddharthkp requested review from mperrotti and broccolinisoup and removed request for mperrotti November 7, 2024 11:20

Create fluffy-days-brake.md

859019e

github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 7, 2024

the tiniest chnage

e427df0

siddharthkp temporarily deployed to github-pages November 7, 2024 11:24 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5230 November 7, 2024 11:24 Inactive

move focus trap for easier review

fca7e79

siddharthkp commented Nov 7, 2024

View reviewed changes

siddharthkp temporarily deployed to github-pages November 7, 2024 11:27 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5230 November 7, 2024 11:27 Inactive

tiny formatting to make it easier to review

f0be480

siddharthkp deployed to github-pages November 7, 2024 11:33 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-5230 November 7, 2024 11:33 View deployment

siddharthkp mentioned this pull request Nov 7, 2024

SelectPanel: Add variant=modal #5198

Closed

13 tasks

broccolinisoup approved these changes Nov 8, 2024

View reviewed changes

broccolinisoup added this pull request to the merge queue Nov 8, 2024

Merged via the queue into main with commit dce754b Nov 8, 2024
43 checks passed

broccolinisoup deleted the selectpanel-use-anchored-position branch November 8, 2024 08:45

primer bot mentioned this pull request Nov 8, 2024

Release tracking (37.4.0) #5239

Merged

siddharthkp mentioned this pull request Nov 8, 2024

Release Tracking (Nov 4 - Nov 15) #5217

Closed

4 tasks

github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Nov 8, 2024

siddharthkp added a commit that referenced this pull request Nov 8, 2024

Revert "SelectPanel: Prepare for non-anchored variants (#5230)"

20c5c25

This reverts commit dce754b.

siddharthkp mentioned this pull request Nov 8, 2024

Revert "SelectPanel: Prepare for non-anchored variants" #5255

Merged

github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024

Revert "SelectPanel: Prepare for non-anchored variants (#5230)" (#5255)

64802f1

This reverts commit dce754b.

siddharthkp changed the title ~~SelectPanel: Prepare for non-anchored variants~~ (reverted) SelectPanel: Prepare for non-anchored variants Nov 11, 2024

siddharthkp added a commit that referenced this pull request Nov 11, 2024

Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…

dc3d2c0

…" (#5255)" This reverts commit 64802f1.

siddharthkp mentioned this pull request Nov 11, 2024

Bring back #5255 "SelectPanel: Prepare for non-anchored variants" #5262

Merged

siddharthkp restored the selectpanel-use-anchored-position branch November 11, 2024 19:10

siddharthkp deleted the selectpanel-use-anchored-position branch November 11, 2024 19:16

siddharthkp added a commit that referenced this pull request Nov 13, 2024

Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…

2d6fa8f

…" (#5255)" This reverts commit 64802f1.

siddharthkp mentioned this pull request Nov 13, 2024

Bring back "SelectPanel: Prepare for non-anchored variants #5230" #5273

Closed

siddharthkp mentioned this pull request Mar 27, 2025

SelectPanel: Add variant=modal #5817

Closed

13 tasks

hectahertz mentioned this pull request Apr 5, 2025

Add Modal variant with declarative buttons to PRC SelectPanel #5883

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(reverted) SelectPanel: Prepare for non-anchored variants #5230

(reverted) SelectPanel: Prepare for non-anchored variants #5230

Uh oh!

siddharthkp commented Nov 5, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

github-actions bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

primer-integration bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

siddharthkp commented Nov 7, 2024

Uh oh!

siddharthkp Nov 7, 2024

Uh oh!

siddharthkp Nov 7, 2024

Uh oh!

siddharthkp Nov 7, 2024 •

edited

Loading

Uh oh!

broccolinisoup left a comment

Uh oh!

Uh oh!

primer-integration bot commented Nov 8, 2024

Uh oh!

Uh oh!

(reverted) SelectPanel: Prepare for non-anchored variants #5230

(reverted) SelectPanel: Prepare for non-anchored variants #5230

Uh oh!

Conversation

siddharthkp commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

github-actions bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

primer-integration bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siddharthkp commented Nov 7, 2024

Uh oh!

siddharthkp Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

siddharthkp Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

siddharthkp Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

broccolinisoup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

primer-integration bot commented Nov 8, 2024

Uh oh!

Uh oh!

siddharthkp commented Nov 5, 2024 •

edited

Loading

changeset-bot bot commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024 •

edited

Loading

primer-integration bot commented Nov 5, 2024 •

edited

Loading

siddharthkp Nov 7, 2024 •

edited

Loading