Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Blankslate): update styles to center description text #5229

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

joshblack
Copy link
Member

The text in Blankslate should be text-align: center instead of justified left 🔍

Changelog

New

Changed

  • Set text-align: center on the Blankslate container

Removed

Rollout strategy

  • Patch release

@joshblack joshblack requested a review from a team as a code owner November 4, 2024 22:56
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: e325c08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@joshblack
Copy link
Member Author

@jonrohan I noticed that in PVC this style is set at the container level and I wanted to ask if we should do it similarly or, since this component accepts children, if we should scope it to the description/heading?

The only concern I would have is that anything rendered as children to Blankslate would also have text alignment this way (which could be intended but I wanted to double check).

Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.48 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

@jonrohan
Copy link
Member

jonrohan commented Nov 4, 2024

since this component accepts children, if we should scope it to the description/heading?

Good point, I would probably scope to just the .Description class. Since scoping on the container will require children to have text-align: left to reset the style

@primer primer bot requested a review from a team as a code owner November 4, 2024 23:04
@github-actions github-actions bot temporarily deployed to storybook-preview-5229 November 4, 2024 23:07 Inactive
@joshblack joshblack added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 33c5086 Nov 5, 2024
43 checks passed
@joshblack joshblack deleted the fix/update-blankslate-to-center-text branch November 5, 2024 17:05
@primer primer bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants