-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Blankslate): update styles to center description text #5229
Conversation
🦋 Changeset detectedLatest commit: e325c08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chef-kiss:
@jonrohan I noticed that in PVC this style is set at the container level and I wanted to ask if we should do it similarly or, since this component accepts children, if we should scope it to the description/heading? The only concern I would have is that anything rendered as children to Blankslate would also have text alignment this way (which could be intended but I wanted to double check). |
size-limit report 📦
|
Good point, I would probably scope to just the |
…mer/react into fix/update-blankslate-to-center-text
The text in Blankslate should be text-align: center instead of justified left 🔍
Changelog
New
Changed
text-align: center
on the Blankslate containerRemoved
Rollout strategy