Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update project to use react-compiler eslint rule and babel plugin #5226

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Nov 4, 2024

Update @primer/react to make use of the react-compiler eslint rule and babel plugin. This change will automatically memoize components that the compiler can detect that follow the rules of hooks. This change will show up in the React devtools with a tag by each component ✨

Note that these tools are current in beta and as such we need to make sure tests don't fail locally and upstream before merging this in.

Changelog

New

Changed

  • Add eslint-plugin for react compiler
  • Update failing code to disable the react-compiler rules
  • Update babel config for local development and rollup to compile with react compiler

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 5b929f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.49 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 98.91 KB (+0.01% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant