Fix HMR errors #5209
Fix HMR errors #5209
Conversation
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
🦋 Changeset detectedLatest commit: db2f82e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (anchorRef.current) { | ||
| // Necessary for HMR reloads | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| if (anchorRef?.current) { |
There was a problem hiding this comment.
Just curious, do we know why this ref is undefined when doing our upstream work in dotcom? 🤔 Specifically for HMR. It seems like something is happening with the context value being passed along that's different from how it's being represented in TS?
There was a problem hiding this comment.
We think it's because the DOM is being replaced, but honestly that's just a theory 😬
There was a problem hiding this comment.
Like @camertron said, we think the DOM is being rebuilt and inserted, which temporarily seems to make the refs undefined. However, it's barely undefined long enough to matter. By the time the page renders, everything is rehydrated and all works fine. But for that split second while it's being swapped out, React throws a fit.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist