Update CSS Module contribution doc to include adding new VRT #5205
Conversation
|
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
Co-authored-by: Josh Black <joshblack@github.com>
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| - **Handling `sx` Prop:** | ||
| - Confirm the `sx` prop behaves correctly with the feature flag enabled. | ||
|
|
||
| #### Visual regression testing | ||
|
|
||
| Validate that no visual regressions occur when the feature flag is enabled. The `vrt*` tests are setup to compare the feature flagged component with the original component and will fail if there is a mismatch. |
There was a problem hiding this comment.
Seems like a good idea! Would we want to make sure we mark them to be removed once the CSS module migration is complete?
There was a problem hiding this comment.
I think we want to keep the dev tests around because they are testing for className override support mainly. When the feature flags are all removed we will then remove the check for enabled vs. default, but we can do that all at once probably since each test uses the same configuration
Adding some info about adding new VRT tests to the CSS Module contribution doc