Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InlineMessage): Convert InlineMessage component to CSS Modules behind feature flag #5204

Merged
merged 12 commits into from
Nov 5, 2024
Merged

feat(InlineMessage): Convert InlineMessage component to CSS Modules behind feature flag #5204

merged 12 commits into from
Nov 5, 2024
+128 −55

Conversation

randall-krauskopf
Copy link
Collaborator

Closes https://github.com/github/primer/issues/4130

Changelog

Changed

Migrated InlineMessage component to CSS Modules behind feature flag.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bd32155

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.5 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5204 October 31, 2024 19:02 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349537

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@randall-krauskopf randall-krauskopf marked this pull request as ready for review October 31, 2024 20:09
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner October 31, 2024 20:09
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 15:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 15:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 16:54 Inactive
@primer primer bot requested a review from a team as a code owner November 4, 2024 17:04
@primer primer bot requested a review from tbenning November 4, 2024 17:04
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 17:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 17:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 20:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5204 November 4, 2024 22:08 Inactive
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 209c9b0 Nov 5, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the inline-message-css-module branch November 5, 2024 23:20
@primer primer bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack joshblack approved these changes

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

@tbenning tbenning Awaiting requested review from tbenning tbenning was automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randall-krauskopf @hussam-i-am @joshblack @langermank