Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: Add accessible names to Overlay dialog examples #5186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TylerJDev
Copy link
Contributor

Adds an accessible name (aria-label) to Overlay dialogs.

Changelog

New

  • Adds aria-label to Overlay dialog examples

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why (Storybook only)

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested a review from a team as a code owner October 29, 2024 13:08
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 785e097

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Oct 29, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5186 October 29, 2024 13:10 Inactive
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.48 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant