Skip to content

Conversation

@joshblack
Copy link
Member

Context https://github.slack.com/archives/C01L618AEP9/p1728656511278919

Update the styles of CounterLabel to work with overrides for color, background color, etc.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Check out the storybook locally
  • Update the default story for CounterLabel to use sx with overrides for color and background color
  • Confirm that the colors match what was given in the override and are not overridden due to specificity

@joshblack joshblack requested a review from a team as a code owner October 11, 2024 15:42
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: e8951fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 11, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5111 October 11, 2024 15:44 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.61 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 97.88 KB (+0.1% 🔺)

@joshblack joshblack added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 802568a Oct 14, 2024
@joshblack joshblack deleted the fix/update-counter-label branch October 14, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants