Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(vrt): update all flags check to read from correct runner #5104

Merged
merged 2 commits into from
Oct 10, 2024
Merged

ci(vrt): update all flags check to read from correct runner #5104

merged 2 commits into from
Oct 10, 2024

Conversation

joshblack
Copy link
Member

Noticed that a PR got in that was failing the vrt and aat runners with flags enabled 🤔 This PR updates the job that these runners roll into so that it checks the correct runner

Changelog

New

Changed

  • Update the runner name to report job status for feature flag runners

Removed

@joshblack joshblack requested a review from a team as a code owner October 10, 2024 17:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ce40f0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 10, 2024
@github-actions github-actions bot added the staff Author is a staff member label Oct 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5104 October 10, 2024 17:12 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.61 KB (0%)
packages/react/dist/browser.umd.js 97.79 KB (0%)

@joshblack joshblack added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 0083642 Oct 10, 2024
43 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch October 10, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @jonrohan