Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Avatar): Move CSS modules feature flag from staff to ga for Avatar component #5062

Merged
merged 3 commits into from
Oct 8, 2024
Merged

chore(Avatar): Move CSS modules feature flag from staff to ga for Avatar component #5062

merged 3 commits into from
Oct 8, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 4, 2024 •
edited
Loading

Changelog

Changed

This moves the CSS modules feature flag from staff to ga for the Avatar component.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 90e0a08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5062 October 4, 2024 00:03 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.75 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 96.98 KB (-0.05% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5062 October 4, 2024 00:06 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 7, 2024 20:39
@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 20:39
@jonrohan jonrohan added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 0f5d5e0 Oct 8, 2024
42 checks passed
@jonrohan jonrohan deleted the css_modules_avatar_ga branch October 8, 2024 00:19
@primer primer bot mentioned this pull request Oct 8, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @broccolinisoup