-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AnchoredOverlay): replace broken stories #5056
fix(AnchoredOverlay): replace broken stories #5056
Conversation
|
size-limit report 📦
|
packages/react/src/AnchoredOverlay/AnchoredOverlay.features.stories.tsx
Outdated
Show resolved
Hide resolved
Uh oh! @francinelucca, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
…0-prcanchoredoverlay-example-overlay-has-fixed-width
Monalisa Octocat | ||
</Text> | ||
</Stack> | ||
<Text fontSize={14}>Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using the size
prop instead.
<Text fontSize={14}>Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text> | |
<Text size="medium">Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text> |
Same goes for other places where you're using Text
to set the size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah perfect, will do! thankss 🙏🏼
packages/react/src/AnchoredOverlay/AnchoredOverlay.features.stories.tsx
Outdated
Show resolved
Hide resolved
…e-overlay-has-fixed-width
…ories.tsx Co-authored-by: Mike Perrotti <mperrotti@github.com>
…e-overlay-has-fixed-width
Relates to https://github.com/github/primer/issues/3420
Current
AnchoredOverlay
stories usingplacekitten
are broken due to the site no longer being available. Replaced with a hovercard example (modeled after mona) as suggested here.Changelog
Changed
placekitten.com
with hovercard exampleRollout strategy
docs only update
Testing & Reviewing
N/A
Merge checklist