Add gap to progressbar with multiple sections #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4283297 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
@lukasoppermann/progressbar
branch
from
3f6627c
to
b8cf221
Compare
size-limit report 📦
|
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
@lukasoppermann/progressbar
branch
from
b8cf221
to
31e5c00
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
TylerJDev
approved these changes
Sep 20, 2024
siddharthkp
reviewed
Sep 20, 2024
siddharthkp
approved these changes
Sep 20, 2024
Co-authored-by: Tyler Jones <tylerjdev@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
TylerJDev
added a commit
that referenced
this pull request
Sep 23, 2024
* add gap to progressbar with multiple sections * update etst * Update packages/react/src/ProgressBar/ProgressBar.tsx Co-authored-by: Tyler Jones <tylerjdev@github.com> * Update .changeset/stale-pets-tan.md Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * update snapshots --------- Co-authored-by: Tyler Jones <tylerjdev@github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was mentioned in slack and is apparent when looking at the docs.
Expected
When a progressbar has multiple sections, a 2px gap is shown between them.
Current behavior
When a progressbar has multiple sections, a no gap is shown between them. making them sometimes very hard to distinguish.
Changelog
sectionscontrol to the playground story to allow users to check the difference.Rollout strategy
Testing & Reviewing
Merge checklist