-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wildcard imports as exports #4976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97c8b54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
temporarily deployed
to
github-pages
September 16, 2024 20:58
— with
GitHub Actions
Inactive
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
September 16, 2024 21:59
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
September 16, 2024 22:07
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
September 18, 2024 20:48
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
September 19, 2024 22:21
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
September 19, 2024 22:52
— with
GitHub Actions
Inactive
bump @siddharthkp when you have a second! |
joshblack
temporarily deployed
to
github-pages
September 24, 2024 16:12
— with
GitHub Actions
Inactive
jonrohan
approved these changes
Sep 24, 2024
Merged
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/343590 |
siddharthkp
added a commit
that referenced
this pull request
Sep 26, 2024
This reverts commit f448b1b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've identified usage of wildcard imports downstream 👀 As a result, this PR adds these imports to named entry points that we have (and also creates a new one).
With these wildcard exports now coming from a named entry point, we can update dotcom to use these new exports before officially removing them ☠️
The full list of wildcard imports identified is at: https://github.com/primer/eslint-plugin-primer-react/blob/main/src/rules/no-wildcard-imports.js#L5
Changelog
New
@primer/react/test-helpers
VisuallyHidden
,VisuallyHiddenProps
to@primer/react
BetterCssProperties
to@primer/react
BetterSystemStyleObject
to@primer/react
IssueLabelTokenProps
to@primer/react
LabelColorOptions
to@primer/react
useIsomorphicLayoutEffect
to@primer/react
useProvidedRefOrCreate
to@primer/react
ActionListGroupedListProps
,ActionListGroupProps
,ActionListItemProps
to@primer/react/deprecated
DefaultFeatureFlags
to@primer/react/experimental
Changed
Removed
Rollout strategy