Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Link component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga #4975

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 16, 2024

Part of https://github.com/github/primer/issues/3719

Changelog

Changed

Change the Link component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 728447c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 16, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4975 September 16, 2024 20:35 Inactive
Copy link
Contributor

github-actions bot commented Sep 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.4 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 97.67 KB (+0.01% 🔺)

@jonrohan jonrohan marked this pull request as ready for review September 16, 2024 20:38
@jonrohan jonrohan requested a review from a team as a code owner September 16, 2024 20:38
@github-actions github-actions bot temporarily deployed to storybook-preview-4975 September 16, 2024 20:39 Inactive
@jonrohan jonrohan added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 0b89fc0 Sep 18, 2024
32 checks passed
@jonrohan jonrohan deleted the css_modules_ga_link branch September 18, 2024 16:31
@primer primer bot mentioned this pull request Sep 18, 2024
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
…staff to primer_react_css_modules_ga (#4975)

* Move Link to ga feature flag

* Create dirty-pianos-wash.md
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants