Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormControl): update Caption to no longer use styled system props #4972

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

joshblack
Copy link
Member

Update our internal component for captions to no longer use styled system props. This caused an issue when our CSS Module flags were enabled since we were no longer forwarding these props along to Box to correctly generate class names

Changelog

New

Changed

  • Update how our internal InputCaption component styles the Text component so that it no longer uses styled-system props

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Verify that when flag is enabled that the Checkbox With Caption story renders as expected

@joshblack joshblack requested a review from a team as a code owner September 16, 2024 19:56
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 6b993e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 16, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4972 September 16, 2024 19:59 Inactive
Copy link
Contributor

github-actions bot commented Sep 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.46 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 97.72 KB (-0.09% 🔽)

@primer primer bot requested a review from a team as a code owner September 16, 2024 20:26
@primer primer bot requested a review from tbenning September 16, 2024 20:26
@joshblack joshblack added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 082b4e7 Sep 16, 2024
32 checks passed
@joshblack joshblack deleted the fix/update-text-checkbox-tests branch September 16, 2024 22:07
@primer primer bot mentioned this pull request Sep 16, 2024
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
…#4972)

* fix(FormControl): update Caption to no longer use styled system props

* chore: add changeset

* test(vrt): update snapshots

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants