Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Button loading spinner color #4941

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Bug fix: Button loading spinner color #4941

merged 4 commits into from
Sep 9, 2024

Conversation

langermank
Copy link
Contributor

Noticed this loading spinner color is wrong as I'm rewriting this component with CSS Modules. Fixing it here to fix my new branch 😄

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: a980a26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.56 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 96.88 KB (-0.03% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4941 September 9, 2024 20:42 Inactive
@langermank langermank marked this pull request as ready for review September 9, 2024 20:47
@langermank langermank requested review from a team as code owners September 9, 2024 20:47
@github-actions github-actions bot temporarily deployed to storybook-preview-4941 September 9, 2024 20:51 Inactive
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@langermank langermank added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 80fe025 Sep 9, 2024
30 checks passed
@langermank langermank deleted the fix-button-spinner branch September 9, 2024 22:01
@primer primer bot mentioned this pull request Sep 9, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants