Skip to content

SegmentedControl: Add context to ariaLabel prop #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Sep 3, 2024

Closes https://github.com/github/primer/issues/3497

Changelog

Changed

  • Updates accessible name of SegmentedControl menu button to contain the visual text, and provided aria-label.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 137634c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.41 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 96.65 KB (+0.03% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/340353

@TylerJDev TylerJDev marked this pull request as ready for review September 4, 2024 02:58
@TylerJDev TylerJDev requested a review from a team as a code owner September 4, 2024 02:58
@TylerJDev TylerJDev requested a review from jonrohan September 4, 2024 02:58
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Wanted to ask if it would be possible to include a test too to make sure we don't miss this in the future? 😅

@TylerJDev TylerJDev added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 9846375 Sep 4, 2024
30 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/segmented-control-accName branch September 4, 2024 20:12
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants