-
Notifications
You must be signed in to change notification settings - Fork 614
SegmentedControl: Add context to ariaLabel
prop
#4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 137634c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/340353 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Wanted to ask if it would be possible to include a test too to make sure we don't miss this in the future? 😅
Closes https://github.com/github/primer/issues/3497
Changelog
Changed
SegmentedControl
menu button to contain the visual text, and providedaria-label
.Rollout strategy
Testing & Reviewing
Merge checklist