LabelGroup: Update "toggle" accessible name to include visual text #4910
Conversation
🦋 Changeset detectedLatest commit: bdc650c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/340287 |
| }) => | ||
| isOverflowShown ? ( | ||
| <Button ref={collapseButtonRef} onClick={collapseInlineExpandedChildren} size="small" variant="invisible"> | ||
| Show less | ||
| </Button> | ||
| ) : hiddenItemIds.length ? ( | ||
| <Button ref={expandButtonRef} variant="invisible" size="small" onClick={showAllTokensInline}> | ||
| <VisuallyHidden>Show all {totalLength}</VisuallyHidden> | ||
| <VisuallyHidden>Show +{hiddenItemIds.length} more</VisuallyHidden> |
There was a problem hiding this comment.
Random question, what does including + here do? Is this changing how it's announced?
There was a problem hiding this comment.
It doesn't really change much. For all the screen readers I tested with (NVDA, VoiceOver, JAWS) they all announced "Show plus 11 more". It would be preferable for it to say "11 plus", but then we'd need to move the + in the visual text to be after the number (e.g. 11+).
…4910) * Update `LabelGroup` truncate button accName * Add changeset
Closes https://github.com/github/primer/issues/3426
Changelog
Changed
LabelGroupto include the visual labelRollout strategy
Testing & Reviewing
Merge checklist