Select Panel: Functional adjustments #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimer/react into select-panel--functional-adjustments-1
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
added
the
integration-tests: recommended
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341539 |
siddharthkp
added
integration-tests: passing
TylerJDev
approved these changes
Sep 11, 2024
TylerJDev
pushed a commit
that referenced
this pull request
Sep 23, 2024
* super wip * just use the actionlist component and revert the type updates * Update packages/react/src/FilteredActionList/FilteredActionList.tsx * Some more progress * revert the type changes and cast it :/ * clean * wip * wip wip * add stories * fix linting * add tests for groups * Map groups * Update story names for e2e tests * oops remove unintended file * update story name * same - update story name * disable animations * test(vrt): update snapshots * Update tests since new action list has different semantics for group headings * logging * pass the rest * extract children and use before text * remove logging * test(vrt): update snapshots * add active styles to ActionList * rename component name to be clearer * remove variant full from examples * tiny clean up * fix showItemDividers * another tiny cleanup * pull MappedActionListItem to make it stable * test(vrt): update snapshots * show active styles only when used with keyboard * backward compat: expose id as data-id * update snapshots * add story for long strings * fishing for errors * backward compatibility for renderItem * remove todo now * add a feature flag * clean up dual filter list setup * run jests test with both states of feature flags * refactor snapshot tests with scenarios * remove feature flag for main * test(vrt): update snapshots * add feature flag to e2e matrix * test(vrt): update snapshots * backward compat: allow groupMetadata to be empty array * sigh newline * Create sour-cooks-dress.md * copy SelectPanel snapshots from main * remove unrelated changes in this PR * test(vrt): update snapshots * add more bindkeys * add for deprecated version as well * label listbox/ActionList by panel title * Create wicked-books-occur.md * remove Home and End * add test for PageDown and PageUp * update changeset * active styles for both directly and indirectly * add role=combobox * update snapshot * test(vrt): update snapshots * remove features from deprecated version * update test * only use aria-labelledby when aria-label is not passed * remove combobox for this PR --------- Co-authored-by: Armagan Ersoz <broccolinisoup@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works only on modern ActionList (feature flag
primer_react_select_panel_with_modern_action_list):Works for both deprecated (feature flag off) and modern ActionList (feature flag on):
listboxby the title of the panelNote: removed
comboboxupdate from this PR because i'm not convinced if that's the right move, created an issue to investigate: https://github.com/github/primer/issues/3951Rollout strategy
Testing & Reviewing
Merge checklist