Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Blankslate): Don't use Box to render heading when flag is enabled #4857

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jonrohan
Copy link
Member

I noticed that in Blankslate we were still using <Box to render the heading when the feature flag was enabled. This was needlessly sending us through the styled components codepath when we didn't need to.

CleanShot 2024-08-16 at 13 35 15@2x

Changelog

Changed

Only render the heading with the styled component when the feature flag is disabled.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: a3f5485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 16, 2024
Copy link
Contributor

Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Contributor

github-actions bot commented Aug 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.27 KB (0%)
packages/react/dist/browser.umd.js 96.55 KB (0%)

@jonrohan jonrohan added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 16c31e6 Aug 16, 2024
30 checks passed
@jonrohan jonrohan deleted the blankslate_heading_box branch August 16, 2024 22:18
@primer primer bot mentioned this pull request Aug 16, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants