Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export FilteredActionList #4816

Merged
merged 5 commits into from
Aug 8, 2024
Merged

export FilteredActionList #4816

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c5667a
export FilteredActionList
siddharthkp Aug 6, 2024
7a29c27
Create new-shirts-beam.md
siddharthkp Aug 6, 2024
db74cae
move FilteredActionList from root to experimental
siddharthkp Aug 8, 2024
80471d7
Merge branch 'main' into export-filtered-actionlist
siddharthkp Aug 8, 2024
839501c
update changelog
siddharthkp Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/new-shirts-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

FilteredActionList: export `FilteredActionList` from '@primer/react'
2 changes: 2 additions & 0 deletions packages/react/src/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ exports[`@primer/react should not update exports without a semver change 1`] = `
"Dialog",
"type DialogHeaderProps",
"type DialogProps",
"FilteredActionList",
"type FilteredActionListProps",
"Flash",
"type FlashProps",
"type FocusTrapHookSettings",
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,6 @@ export type {PageHeaderProps} from './PageHeader'
export {SSRProvider, useSSRSafeId} from './utils/ssr'
export {default as sx, merge} from './sx'
export type {SxProp} from './sx'

export {FilteredActionList} from './FilteredActionList'
export type {FilteredActionListProps} from './FilteredActionList'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for reviewer:

Should we export this from experimental instead? It isn't really experimental because it's been what powers SelectPanel from the start.

But if we want to treat this as a temporary solution, then it feels okay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down with experimental if it means we won't have to go through a deprecated flow 😂 But if we still have to go through that, then stable is fine 👍

(Separate from this PR) this could be a good example for spots where an unstable_* convention could help out without having to couple things to entry points

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that it would be great to treat it as an experimental/unstable component so that we don't have to worry about semver in case if we need to make any changes for the SelectPanel remediation.

Copy link
Member Author

@siddharthkp siddharthkp Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid, moved it to experimental

Loading