Skip to content

test test #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
broccolinisoup wants to merge 3 commits into from
Closed

test test #4815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8416113
test test
broccolinisoup Aug 6, 2024
f2d6b52
test
broccolinisoup Aug 6, 2024
f1c6fc5
not check the disable state with a css selector
broccolinisoup Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/react/src/TooltipV2/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,20 +169,14 @@ const positionToDirection: Record<string, TooltipDirection> = {
}

// The list is from GitHub's custom-axe-rules https://github.com/github/github/blob/master/app/assets/modules/github/axe-custom-rules.ts#L3
const interactiveElements = [
'a[href]',
'button:not(:disabled)',
'summary',
'select',
'input:not([type=hidden])',
'textarea',
]
const interactiveElements = ['a[href]', 'button', 'summary', 'select', 'input:not([type=hidden])', 'textarea']

const isInteractive = (element: HTMLElement) => {
return (
const notDisabled = !element.hasAttribute('disabled')
const interactive =
interactiveElements.some(selector => element.matches(selector)) ||
(element.hasAttribute('role') && element.getAttribute('role') === 'button')
)
return notDisabled && interactive
}
export const TooltipContext = React.createContext<{tooltipId?: string}>({})

Expand Down Expand Up @@ -249,6 +243,7 @@ export const Tooltip = React.forwardRef(
const hasInteractiveChild = Array.from(triggerChildren).some(child => {
return child instanceof HTMLElement && isInteractive(child)
})
// console.log('test logging', triggerRef.current, isTriggerInteractive, hasInteractiveChild)
invariant(
isTriggerInteractive || hasInteractiveChild,
'The `Tooltip` component expects a single React element that contains interactive content. Consider using a `<button>` or equivalent interactive element instead.',
Expand Down