-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionList: Ensure variant
is respected when full
#4706
Conversation
🦋 Changeset detectedLatest commit: 1f96ef5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/331186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to ask if there was a good way to add a test for this kind of change. Is this something that VRT could help out with or would this be more of a Jest thing?
That's a good point! I think a VRT would be perfect! I believe this wasn't caught because we don't test for |
When
ActionList
utilized thefull
variant, the style was not applying correctly (behind feature flag). This fix ensures that thevariant
is respected when the FF is enabled.This change will only affect
ActionList
behind its feature flag (primer_react_action_list_item_as_button
).Changelog
Changed
variant
is respected whenfull
and FF is enabledRollout strategy
Testing & Reviewing
Merge checklist