Update the default value of unsafeDisableTooltip to false and remove redundant props and wrappers
#4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unncessary props and wrappers
🦋 Changeset detectedLatest commit: fd6bd57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
unsafeDisableTooltip to false and remove redundant props and wrappers
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
unsafeDisableTooltip to false and remove redundant props and wrappersunsafeDisableTooltip to false and remove redundant props and wrappers
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
commented
Jul 3, 2024
| @@ -140,7 +169,9 @@ describe('Dialog', () => { | |||
| }) | |||
|
|
|||
| it('Returns focus to returnFocusRef on escape', async () => { | |||
| const {getByTestId, queryByTestId} = HTMLRender(<Component />) | |||
There was a problem hiding this comment.
I had an issue with this existing component. It was supposed to go back to the return ref after pressing the ESC twice (First closing the tooltip, second closing the dialog) but for some reason it didn't work, even though I waited for the previous keyboard event to be completed. This test wasn't about the tooltip itself; it is about the Dialog so I updated to use a different dialog but let me know if I am misinterpreting the issue I encountered.
broccolinisoup
changed the title
unsafeDisableTooltip to false and remove redundant props and wrappersunsafeDisableTooltip to false and remove redundant props and wrappers
siddharthkp
reviewed
Jul 8, 2024
| @@ -11,7 +11,8 @@ export default { | |||
|
|
|||
| export const IconButtons = () => ( | |||
| <ButtonGroup> | |||
| <IconButton icon={PlusIcon} aria-label="Add" /> | |||
| <IconButton icon={DashIcon} aria-label="Subtract" /> | |||
| {/* We can remove these unsafe props after we resolve https://github.com/primer/react/issues/4129 */} | |||
siddharthkp
reviewed
Jul 8, 2024
| @@ -11,6 +11,7 @@ import type {ComponentProps} from './utils/types' | |||
| import {useRefObjectAsForwardedRef} from './hooks/useRefObjectAsForwardedRef' | |||
| import {XIcon} from '@primer/octicons-react' | |||
|
|
|||
| // Dialog v1 | |||
siddharthkp
approved these changes
Jul 8, 2024
siddharthkp
added
react
integration-tests: recommended
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/332110 |
|
Integration tests pass https://github.com/github/github/pull/332110 and tested on RL, everything looks good 🎉 |
Merged
siddharthkp
added
integration-tests: passing
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2008
Related #4696
Note
We managed to complete the roll out at dotcom 🎉 (View the progress here (internal link only))
Changelog
Changed
unsafeDisableTooltipto falseunsafeDisableTooltip={true}a coupe of IconButton instances where it is not safe to enable tooltips.Removed
unsafeDisableTooltip={false}prop since it is the default value now.Rollout strategy
Testing & Reviewing
Merge checklist