fix(Spinner): update visually hidden container to span #4689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during our release cycle this week, specifically where changes to spinner cause
validateDOMNesting
errors due toSpinner
usage within a<p>
. In this case, an error would occur sincediv
is not allowed withinp
. This change updates the visually hidden container to aspan
to address this.Changelog
New
Changed
Spinner
's visually hidden area to aspan
Removed
Rollout strategy