Skip to content

fix(Spinner): update visually hidden container to span #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

joshblack
Copy link
Member

This came up during our release cycle this week, specifically where changes to spinner cause validateDOMNesting errors due to Spinner usage within a <p>. In this case, an error would occur since div is not allowed within p. This change updates the visually hidden container to a span to address this.

Changelog

New

Changed

  • Update tag for Spinner's visually hidden area to a span

Removed

Rollout strategy

  • [ x Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 20, 2024
@joshblack joshblack requested a review from a team as a code owner June 20, 2024 18:07
@joshblack joshblack requested a review from keithamus June 20, 2024 18:07
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 723217f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack requested a review from jonrohan June 20, 2024 18:07
@joshblack joshblack enabled auto-merge June 20, 2024 18:08
Copy link
Contributor

github-actions bot commented Jun 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.83 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 91.08 KB (-0.08% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4689 June 20, 2024 18:15 Inactive
@joshblack joshblack added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 7c2de02 Jun 20, 2024
30 checks passed
@joshblack joshblack deleted the fix/update-visually-hidden-to-span branch June 20, 2024 19:42
@joshblack joshblack mentioned this pull request Jun 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants