Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps eslint-plugin-github and eliminates false positive a11y rule flag #4649

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jun 6, 2024

Relates to: https://github.com/github/accessibility/issues/5304

Changelog

This PR bumps the eslint-plugin-github to the latest release. With this release, the no-redundant-roles rule will stop flagging two false positive reports, because of an update we made in: github/eslint-plugin-github#531.

These two lint disables have been showing up as needing resolution in Primer's Accessibility Automation scorecard. @pksjce and @TylerJDev provided very helpful feedback in https://github.com/github/accessibility/discussions/4921 that these are false positives and how setting role="rowgroup" explicitly is necessary in order to improve screen reader semantics.

Based on this feedback, we excluded redundant use of role="rowgroup" from being flagged in the linting config since:

  1. All reported instances were necessary to improve screen reader semantics to get around an AT/browser bug.
  2. Redundant use of role isn't actually harmful for accessibility, and is more of a readability/best practice. It is worth continuing to enforce, but its not the end of the world if we don't flag it for role="rowgroup".

Thank you very much for reporting this and we apologize for the delay in following-up. We hope to follow-up with the other instances as well.

Removed

  • Two lint disables that are no longer relevant so it will not be counted in the accessibility scorecard.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@khiga8 khiga8 added the skip changeset This change does not need a changelog label Jun 6, 2024
@khiga8 khiga8 requested a review from a team as a code owner June 6, 2024 18:35
@khiga8 khiga8 requested a review from owenniblock June 6, 2024 18:35
Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: cc6597a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8 khiga8 requested review from pksjce and TylerJDev June 6, 2024 18:35
Copy link
Contributor

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.45 KB (0%)
packages/react/dist/browser.umd.js 89.79 KB (0%)

Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@khiga8 khiga8 added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit d2ab5e2 Jun 7, 2024
37 checks passed
@khiga8 khiga8 deleted the kh-bump-linting-plugins branch June 7, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants