Bumps eslint-plugin-github and eliminates false positive a11y rule flag #4649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: https://github.com/github/accessibility/issues/5304
Changelog
This PR bumps the
eslint-plugin-github
to the latest release. With this release, theno-redundant-roles
rule will stop flagging two false positive reports, because of an update we made in: github/eslint-plugin-github#531.These two lint disables have been showing up as needing resolution in Primer's Accessibility Automation scorecard. @pksjce and @TylerJDev provided very helpful feedback in https://github.com/github/accessibility/discussions/4921 that these are false positives and how setting
role="rowgroup"
explicitly is necessary in order to improve screen reader semantics.Based on this feedback, we excluded redundant use of
role="rowgroup"
from being flagged in the linting config since:role="rowgroup"
.Thank you very much for reporting this and we apologize for the delay in following-up. We hope to follow-up with the other instances as well.
Removed
Rollout strategy