Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jest-axe with axe-core #4590

Merged
merged 5 commits into from
May 16, 2024
Merged

Replace jest-axe with axe-core #4590

merged 5 commits into from
May 16, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented May 13, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3284

Changelog

Changed

  • Removes jest-axe in favor of using axe-core
  • Adds @github/axe-github
  • Adds custom matcher toHaveNoViolations()

Removed

  • Removes jest-axe
  • Removes custom axe rule in favor of @github/axe-github

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f314fd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.34 KB (0%)
packages/react/dist/browser.umd.js 88.65 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4590 May 13, 2024 23:03 Inactive
@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label May 14, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4590 May 14, 2024 00:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4590 May 14, 2024 18:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4590 May 15, 2024 00:47 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review May 15, 2024 01:52
@TylerJDev TylerJDev requested a review from a team as a code owner May 15, 2024 01:52
@TylerJDev TylerJDev requested a review from langermank May 15, 2024 01:52
@TylerJDev TylerJDev mentioned this pull request May 16, 2024
Closed
13 tasks
joshblack
joshblack approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 🥳

@joshblack joshblack added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit e090b73 May 16, 2024
33 checks passed
@joshblack joshblack deleted the tylerjdev/replace-jest-axe branch May 16, 2024 16:58
JelloBagel pushed a commit that referenced this pull request May 16, 2024
@TylerJDev @JelloBagel
Replace jest-axe with axe-core (#4590)
1bbd0bc 
* Replace `jest-axe` with `axe-core` directly

* Update axe-core package

* Update message

* Add `axe-github`, replace custom rules

* Add custom rules to Jest setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJDev @joshblack