Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds FormControl's "Auto-Wiring" to SelectPanel v2 Component #4389

Merged
merged 21 commits into from
Apr 24, 2024
Merged

Adds FormControl's "Auto-Wiring" to SelectPanel v2 Component #4389

merged 21 commits into from
Apr 24, 2024

Commits on Mar 13, 2024

  1. autowires SelectPanelv2 to FormControl

    @JeffreyKozik
    JeffreyKozik committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0f4cec5 View commit details
    Browse the repository at this point in the history

  2. added changeset

    @JeffreyKozik
    JeffreyKozik committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    06b048a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Update afraid-beds-lick.md

    @siddharthkp
    siddharthkp authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5e46bce View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Button is aria-labelledby by 2 different components now

    @JeffreyKozik
    JeffreyKozik committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d1df0dd View commit details
    Browse the repository at this point in the history

  2. using querySelector instead of VisuallyHidden approach

    @JeffreyKozik
    JeffreyKozik committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3d69e09 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into jeffreykozik/autolinking_selectpanelv2_to_fo… 

    …rmcontrol
    @JeffreyKozik
    JeffreyKozik authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    969c97c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Added visually hidden punctuation

    @JeffreyKozik
    JeffreyKozik committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4d7b5d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. removed selectPanelButtonId

    @JeffreyKozik
    JeffreyKozik committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    616ad2b View commit details
    Browse the repository at this point in the history

  2. hiding visuallyhidden text from screen readers as well

    @JeffreyKozik
    JeffreyKozik committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d26d79a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. use ariaLabel instead of ariaLabelledby

    @JeffreyKozik
    JeffreyKozik committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    d6b08a2 View commit details
    Browse the repository at this point in the history

  2. added a 2nd test for complex button case

    @JeffreyKozik
    JeffreyKozik committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    6ea27c7 View commit details
    Browse the repository at this point in the history

  3. updated tests

    @JeffreyKozik
    JeffreyKozik committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    006a61b View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'main' into jeffreykozik/autolinking_selectpanelv2_to_fo… 

    …rmcontrol
    @JeffreyKozik
    JeffreyKozik authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e8aa873 View commit details
    Browse the repository at this point in the history

  2. using aria-labelledby to reference itself, updated tests

    @JeffreyKozik
    JeffreyKozik committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    672aaab View commit details
    Browse the repository at this point in the history

  3. flipped order within aria-label

    @JeffreyKozik
    JeffreyKozik committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c3e1594 View commit details
    Browse the repository at this point in the history

  4. updated conditional, added negative test

    @JeffreyKozik
    JeffreyKozik committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    71ea3b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'main' into jeffreykozik/autolinking_selectpanelv2_to_fo… 

    …rmcontrol
    @JeffreyKozik
    JeffreyKozik authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a3db265 View commit details
    Browse the repository at this point in the history

  2. removed aria-labelledby

    @JeffreyKozik
    JeffreyKozik committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e6d93e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into jeffreykozik/autolinking_selectpanelv2_to_fo… 

    …rmcontrol
    @JeffreyKozik
    JeffreyKozik authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    38d9748 View commit details
    Browse the repository at this point in the history

  2. test

    @JeffreyKozik
    JeffreyKozik committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    856e957 View commit details
    Browse the repository at this point in the history

  3. fix

    @JeffreyKozik
    JeffreyKozik committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    eacfa7c View commit details
    Browse the repository at this point in the history