Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup: Fix button and icon button styling when tooltips are used on them #4371

Closed
wants to merge 23 commits into from

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 8, 2024

Closes #4129

Changelog

New

Changed

  • With this PR, we are wrapping button group items with a div. The main reason is to simplify CSS selection. You can view the previous attempt to write a CSS to fix styling issues both for tooltip v1 and v2 on button group.
  • Enhanced CSS selection for the ButtonGroup children elements to ensure buttons and links still look the same if there are tooltips on them

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 8, 2024
Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: ea8b026

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.23 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 91.48 KB (-0.03% 🔽)

@primer-integration
Copy link

primer-integration bot commented Jul 1, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/331337

@broccolinisoup broccolinisoup changed the title Explore wrapping button group items with a div to simplify css selection ButtonGroup: Fix button and icon button styling when tooltips are used on them Jul 3, 2024
@broccolinisoup
Copy link
Member Author

closing in favour of #4723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using <Tooltip> within <ButtonGroup> affects styling
1 participant