Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tooltip id in docs.json #4370

Merged
merged 1 commit into from
Mar 8, 2024
Merged

update tooltip id in docs.json #4370

merged 1 commit into from
Mar 8, 2024

Conversation

broccolinisoup
Copy link
Member

Tooltip v2 doesn't appear on the https://primer.style/components/tooltip due to having a wrong id. For all versions of tooltip to be appear on the same docs page, they need to have the same id which is tooltip

Changelog

New

Changed

Updated the tooltip v2's id to be the same as v1 for consolidation on the new docs site

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why - docs change

Testing & Reviewing

Merge checklist

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 7, 2024
@broccolinisoup broccolinisoup requested a review from a team as a code owner March 7, 2024 22:58
Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: 9473cd1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.71 KB (0%)
packages/react/dist/browser.umd.js 114.38 KB (0%)

Copy link
Collaborator

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 5c7571c Mar 8, 2024
34 checks passed
@broccolinisoup broccolinisoup deleted the tooltip-id-update branch March 8, 2024 01:04
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants