Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip2: Render tooltip element as span #4360

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Tooltip2: Render tooltip element as span #4360

merged 3 commits into from
Mar 7, 2024

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 6, 2024 •
edited
Loading

Tooltip is rendered as div however it ends up creating an invalid nested elements

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

(integration test fail)

Changelog

New

Changed

render tooltip as span instead of div

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7060be2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.69 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 114.37 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4360 March 6, 2024 09:47 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review March 6, 2024 11:49
@broccolinisoup broccolinisoup requested review from a team, pksjce and siddharthkp March 6, 2024 11:49
@siddharthkp siddharthkp requested review from pksjce and removed request for pksjce March 7, 2024 09:53
@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 5baf736 Mar 7, 2024
31 checks passed
@broccolinisoup broccolinisoup deleted the tooltip-span branch March 7, 2024 10:48
@primer primer bot mentioned this pull request Mar 7, 2024
Merged
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
@broccolinisoup @lukasoppermann
Tooltip2: Render tooltip element as span (#4360)
b2e4df6 
* render tooltip as span

* Create wicked-rings-prove.md

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@keithamus keithamus keithamus approved these changes

@pksjce pksjce Awaiting requested review from pksjce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broccolinisoup @keithamus @siddharthkp