Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel2: Add back button #4288

Merged
merged 13 commits into from
Mar 7, 2024
Merged

SelectPanel2: Add back button #4288

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5a09f6e
add back button
siddharthkp Feb 20, 2024
9c956fa
add nested panel example
siddharthkp Feb 20, 2024
72e9a9c
fix nested panel focus
siddharthkp Feb 20, 2024
24105ab
implement save and cancel on second panel
siddharthkp Feb 20, 2024
73b6b15
add onCancel for first panel
siddharthkp Feb 20, 2024
b154b45
Create fair-sloths-kick.md
siddharthkp Feb 20, 2024
6f91cb8
add preview for selection
siddharthkp Feb 20, 2024
f70872e
show dividers
siddharthkp Feb 21, 2024
52dace8
hide selection in story
siddharthkp Feb 21, 2024
7ebfbfb
update snapshots
siddharthkp Feb 21, 2024
ae2172f
make the first ActionList role=list
siddharthkp Feb 28, 2024
435c646
add warning to story
siddharthkp Feb 28, 2024
065f107
Merge branch 'main' into drafts-selectpanel-back-button
siddharthkp Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-sloths-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

experimental/SelectPanel: Add back button
6 changes: 4 additions & 2 deletions packages/react/src/ActionList/Selection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export const Selection: React.FC<React.PropsWithChildren<SelectionProps>> = ({se
}

if (selectionVariant === 'single' || listRole === 'menu') {
return <LeadingVisualContainer>{selected && <CheckIcon />}</LeadingVisualContainer>
return (
<LeadingVisualContainer data-component="ActionList.Selection">{selected && <CheckIcon />}</LeadingVisualContainer>
)
}

/**
Expand Down Expand Up @@ -59,7 +61,7 @@ export const Selection: React.FC<React.PropsWithChildren<SelectionProps>> = ({se
}

return (
<LeadingVisualContainer>
<LeadingVisualContainer data-component="ActionList.Selection">
<Box
sx={{
borderColor: selected ? 'accent.fg' : 'neutral.emphasis',
Expand Down
Loading
Loading