test(e2e): add e2e test for SelectPanel2 default story #4279

joshblack · 2024-02-16T20:20:21Z

Context https://github.com/github/primer/issues/3025

This PR adds the first e2e test for SelectPanel2 for its default story. It also addresses the axe violation that shows up for the role="listbox" by labeling it by the title id for the dialog

Changelog

New

Add e2e test for SelectPanel2

Changed

Add listLabelledBy as context value for ActionList

Removed

Rollout strategy

Patch release

Testing & Reviewing

Does the change for the aria-labelledby make sense? will this always be available or is this something teams should provide?

changeset-bot · 2024-02-16T20:20:25Z

🦋 Changeset detected

Latest commit: 9bec151

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-02-16T20:24:20Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	113.37 KB (0%)
packages/react/dist/browser.umd.js	114.03 KB (0%)

siddharthkp · 2024-02-20T11:58:57Z

packages/react/src/drafts/SelectPanel2/SelectPanel.tsx

@@ -299,6 +299,7 @@ const Panel: React.FC<SelectPanelProps> = ({
                  selectionAttribute: 'aria-selected',
                  selectionVariant: selectionVariant === 'instant' ? 'single' : selectionVariant,
                  afterSelect: internalAfterSelect,
+                  listLabelledBy: `${panelId}--title`,


siddharthkp

These look great!

* fix(SelectPanel2): add aria-labelledby to listbox * test(e2e): add e2e test for SelectPanel2 default story * chore: add changeset * test(vrt): update snapshots --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Add fixes for ActionList * More type fixes * temp type fixes * Add condition for inactive items * add yet another condition * chore(deps): bump changesets/action from 1.4.5 to 1.4.6 (#4282) Bumps [changesets/action](https://github.com/changesets/action) from 1.4.5 to 1.4.6. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@f13b1ba...e2f8e96) --- updated-dependencies: - dependency-name: changesets/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(e2e): add e2e test for SelectPanel2 default story (#4279) * fix(SelectPanel2): add aria-labelledby to listbox * test(e2e): add e2e test for SelectPanel2 default story * chore: add changeset * test(vrt): update snapshots --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Address a few v8 color bugs (#4278) * small bug fixes with v8 * Create khaki-schools-lay.md * test(vrt): update snapshots * snippy snaps * test(vrt): update snapshots * test: update snapshots * test: update snapshots * try commenting flakey tests * test: comment out flakey snapshot test --------- Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump ip from 2.0.0 to 2.0.1 (#4291) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Change how `ref` is handled * Change types * Update storybook example types * Update types on component * Add another type * Update type in `SegmentedControl` * Add back `li`-only type * Add onto `onSelect` type * Update more types * Type fixes for `LinkItem` * Changes from feedback * Change types * Replace `role="list"` with context * Add feature flag to `ActionList.Item * Add back forwardedRef in cases where valid role is true * Update FF name * Add lint disable * Update FF name * Add changeset * Remove `list` condition * Rename FF * Address feedback * Add feature flag story * Add new test * Add feature flag to all stories --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> Co-authored-by: langermank <langermank@users.noreply.github.com>

* Add fixes for ActionList * More type fixes * temp type fixes * Add condition for inactive items * add yet another condition * chore(deps): bump changesets/action from 1.4.5 to 1.4.6 (#4282) Bumps [changesets/action](https://github.com/changesets/action) from 1.4.5 to 1.4.6. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@f13b1ba...e2f8e96) --- updated-dependencies: - dependency-name: changesets/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(e2e): add e2e test for SelectPanel2 default story (#4279) * fix(SelectPanel2): add aria-labelledby to listbox * test(e2e): add e2e test for SelectPanel2 default story * chore: add changeset * test(vrt): update snapshots --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Address a few v8 color bugs (#4278) * small bug fixes with v8 * Create khaki-schools-lay.md * test(vrt): update snapshots * snippy snaps * test(vrt): update snapshots * test: update snapshots * test: update snapshots * try commenting flakey tests * test: comment out flakey snapshot test --------- Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump ip from 2.0.0 to 2.0.1 (#4291) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Change how `ref` is handled * Change types * Update storybook example types * Update types on component * Add another type * Update type in `SegmentedControl` * Add back `li`-only type * Add onto `onSelect` type * Update more types * Type fixes for `LinkItem` * Changes from feedback * Change types * Replace `role="list"` with context * Add feature flag to `ActionList.Item * Add back forwardedRef in cases where valid role is true * Update FF name * Add lint disable * Update FF name * Add changeset * Remove `list` condition * Rename FF * Address feedback * Add feature flag story * Add new test * Add export * Updated forwardRef to be polymorphic * Spike: Add trailingAction to ActionList.Item Co-authored-by: Tyler Jones <tylerjdev@github.com> * Updated forwardRef to be polymorphic * TrailingAction style adjustments * test(vrt): update snapshots * Remove unused story * Limit TrailingAction props * Fix missing href for as link * Add Inactive example * Add styles for `showOnHover` * Fixed href overload issue Co-authored-by: Tyler Jones <tylerjdev@github.com> * Made sure that TrailingAction doesn't show when inactive state Co-authored-by: Tyler Jones <tylerjdev@github.com> * test(vrt): update snapshots * Add fixes for button styles * Fix for flex styles * Update storybookd descriptions * Add block description example * Add tests * Remove FF from tests * update e2e stories * spike on allowing text (#4659) * spike on allowing text * showOnHover support * Add overflow example * Add visual tests * Update from display to visibility * Create calm-crabs-raise.md * Disallow usage in `ActionMenu` * Update ActionList.test.tsx * Remove hover/focus styles * test(vrt): update snapshots * Apply suggestions from code review * Apply suggestions from code review * Fix merge conflict * Remove Hover examples * Remove showOnHover code * Add FF const back * Remove some usage of `hoverStyles` * test(vrt): update snapshots * Add props to TrailingAction * update types Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * update docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tyler Jones <tylerjdev@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: khiga8 <khiga8@users.noreply.github.com> Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>

joshblack added 2 commits February 16, 2024 14:17

fix(SelectPanel2): add aria-labelledby to listbox

bef2867

test(e2e): add e2e test for SelectPanel2 default story

15afde4

joshblack requested review from siddharthkp and a team February 16, 2024 20:20

joshblack added the update snapshots label Feb 16, 2024

chore: add changeset

9eede6f

joshblack changed the title ~~3025 add e2e tests select panel~~ test(e2e): add e2e test for SelectPanel2 default story Feb 16, 2024

joshblack deployed to github-pages February 16, 2024 20:24 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-4279 February 16, 2024 20:25 Inactive

test(vrt): update snapshots

9bec151

github-actions bot removed the update snapshots label Feb 16, 2024

primer bot deployed to github-pages February 16, 2024 20:31 View deployment

github-actions bot deployed to storybook-preview-4279 February 16, 2024 20:32 View deployment

siddharthkp reviewed Feb 20, 2024

View reviewed changes

siddharthkp approved these changes Feb 20, 2024

View reviewed changes

joshblack added this pull request to the merge queue Feb 20, 2024

Merged via the queue into main with commit a68e2e2 Feb 20, 2024
30 checks passed

joshblack deleted the 3025-add-e2e-tests-select-panel branch February 20, 2024 19:11

primer bot mentioned this pull request Feb 20, 2024

Release tracking #4292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(e2e): add e2e test for SelectPanel2 default story #4279

test(e2e): add e2e test for SelectPanel2 default story #4279

joshblack commented Feb 16, 2024

changeset-bot bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

siddharthkp Feb 20, 2024

siddharthkp left a comment

test(e2e): add e2e test for SelectPanel2 default story #4279

test(e2e): add e2e test for SelectPanel2 default story #4279

Conversation

joshblack commented Feb 16, 2024

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

changeset-bot bot commented Feb 16, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Feb 16, 2024 • edited Loading

size-limit report 📦

siddharthkp Feb 20, 2024

Choose a reason for hiding this comment

siddharthkp left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading