-
Notifications
You must be signed in to change notification settings - Fork 616
IconButton: introduce tooltips on icon buttons behind the unsafeDisableTooltip
prop for an incremental rollout
#4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a4cef3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Hi! Optional feedback about strategy that has less steps: https://github.com/github/primer/discussions/3027#discussioncomment-8409508 (sorry for changing the strategy on you!)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the rogue snapshot test!
This PR introduces the tooltip behaviour on icon buttons with an option to be able to disable it with disable
unsafeDisableTooltip
prop. It is based on our team discussion https://github.com/github/primer/discussions/3027Changelog
New
unsafeDisableTooltip
prop is added with the default value oftrue
tooltipDirection
prop is added to icon button as an optional prop.description
prop is added to icon button as an optional prop to add additional text to icon buttons (I.e. an icon button named with "Notifications" and "You have unread notifications" as a description to provide extra information)Changed
unsafeDisableTooltip
prop is passed asfalse
, IconButton is going to be rendered with a tooltip.listLabelledBy
attribute on the ActionMenu.Overlay returns the tooltip id if the menu anchor is an icon button.Removed
Nothing
Rollout strategy
We do not expect any change in icon buttons with this PR. This is the first step of the roll out strategy.
Testing & Reviewing
Merge checklist