ci: update deploy preview workflows to use new format #4087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our deploy preview workflows after the changes last week
Changelog
New
Changed
deploy_preview
to only run if not a forkdeploy_preview_forks
to use new workflowRemoved
Rollout strategy
Testing & Reviewing
One that that's important when using
pull_request_target
is that we do not execute code with access to any permissions that the repo has. As a result, permissions are scoped to the job when using secrets from the repo. Would love a review on this to make sure that we're not leaking anything from a security perspective with these changes 🙏