Skip to content

ci: update deploy preview workflows to use new format #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

joshblack
Copy link
Member

Update our deploy preview workflows after the changes last week

Changelog

New

Changed

  • Update deploy_preview to only run if not a fork
  • Update deploy_preview_forks to use new workflow

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

Testing & Reviewing

One that that's important when using pull_request_target is that we do not execute code with access to any permissions that the repo has. As a result, permissions are scoped to the job when using secrets from the repo. Would love a review on this to make sure that we're not leaking anything from a security perspective with these changes 🙏

@joshblack joshblack requested review from a team and siddharthkp December 19, 2023 16:31
Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: d64ef85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Dec 19, 2023
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.73 KB (0%)
dist/browser.umd.js 105.28 KB (0%)

@joshblack joshblack added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 087b0e6 Dec 19, 2023
@joshblack joshblack deleted the ci/update-deploy-workflows branch December 19, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants