Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct width of AvatarStack #4082

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Correct width of AvatarStack #4082

merged 6 commits into from
Dec 20, 2023

Conversation

mperrotti
Copy link
Contributor

Closes #3964

Screenshots

The backgrounds of the AvatarStack container in these screenshots have been colored pink for demonstration purposes.

Before:
Screenshot 2023-12-18 at 1 14 48 PM

After:
Screenshot 2023-12-18 at 1 16 12 PM

Changelog

New

Changed

  • Corrects the math to calculate the width of AvatarStack containers.
  • Prevents .pc-AvatarStackBody from being removed from document flow by position: absolute. This isn't strictly necessary now that we're correctly setting the width of the stack, but it's an extra level of safety for preserving the correct layout.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested review from a team and siddharthkp December 18, 2023 18:23
Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: b755e36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

Copy link
Contributor

github-actions bot commented Dec 18, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.72 KB (-0.02% 🔽)
dist/browser.umd.js 105.28 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4082 December 18, 2023 20:44 Inactive
@mperrotti mperrotti changed the title Corrects width of AvatarStack Correct width of AvatarStack Dec 19, 2023
Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@mperrotti mperrotti added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit c2809d6 Dec 20, 2023
31 checks passed
@mperrotti mperrotti deleted the mp/avatar-stack-width-fix branch December 20, 2023 21:18
@primer primer bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvatarStack has a fixed width set when disableExpand is set.
2 participants