Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45 #4074

Merged
merged 3 commits into from
Dec 19, 2023
Merged

chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45 #4074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c7f477
chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45
dependabot[bot] Dec 19, 2023
2e88bee
fix(Select): add placeholder prop
joshblack Dec 19, 2023
dc8690f
chore: add changeset
joshblack Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-pandas-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update types for Select to include `placeholder`
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"@types/lodash.isobject": "3.0.7",
"@types/lodash.keyby": "4.6.7",
"@types/node": "20.10.3",
"@types/react": "18.2.21",
"@types/react": "18.2.45",
"@types/react-dom": "18.2.6",
"@types/semver": "7.5.3",
"@types/styled-components": "^5.1.26",
Expand Down
4 changes: 3 additions & 1 deletion src/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {SxProp, merge, BetterSystemStyleObject} from './sx'
export type SelectProps = Omit<
Omit<React.ComponentPropsWithoutRef<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
>
> & {
placeholder?: string
}

const arrowRightOffset = '4px'

Expand Down
4 changes: 3 additions & 1 deletion src/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import TextInputWrapper, {StyledWrapperProps} from '../internal/components/TextI
export type SelectProps = Omit<
Omit<React.ComponentPropsWithoutRef<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
>
> & {
placeholder?: string
}

const arrowRightOffset = '4px'

Expand Down
Loading