Include CSS Custom Property for mono font family #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2c6282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
✨✨ The PR has been updated by @joshblack with changes produced using Copilot Workspace using Copilot Workspace v0.6 TopicAdd a changeset with a random name that describes these changes and tag it as a minor release Before
After
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Dec 8, 2023
Comment on lines
+25
to
+33
| mono: fontStack([ | ||
| 'var(--fontStack-monospace)', | ||
| 'SFMono-Regular', | ||
| 'Consolas', | ||
| 'Liberation Mono', | ||
| 'Menlo', | ||
| 'Courier', | ||
| 'monospace', | ||
| ]), |
There was a problem hiding this comment.
Suggested change
| mono: fontStack([ | |
| 'var(--fontStack-monospace)', | |
| 'SFMono-Regular', | |
| 'Consolas', | |
| 'Liberation Mono', | |
| 'Menlo', | |
| 'Courier', | |
| 'monospace', | |
| ]), | |
| mono: fontStack([ | |
| 'var(--fontStack-monospace, | |
| SFMono-Regular, | |
| Consolas, | |
| Liberation Mono, | |
| Menlo, | |
| Courier, | |
| monospace)', | |
| ]), |
I think it should be like this, but I'm not 100% sure.
There was a problem hiding this comment.
I am now 95% sure I am wrong.
There was a problem hiding this comment.
Yeah, I think either version works
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
approved these changes
Dec 12, 2023
siddharthkp
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by Copilot Workspace 🤯
This pull request includes a change to the
monoproperty of thefontsconstant in thesrc/theme.tsfile. The change adds'var(--fontStack-monospace)'to the beginning of the font stack for monospace fonts.