Skip to content

SelectPanel2: Use html dialog #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

SelectPanel2: Use html dialog #4018

wants to merge 34 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Dec 5, 2023 •
edited
Loading

siddharthkp and others added 30 commits November 7, 2023 15:52
@siddharthkp
breaking changes + cleanup
6a12091
@siddharthkp
add SelectPanel.Warning
f584204
@siddharthkp
add link styles
6d56c15
@siddharthkp
remove todo story :)
6a30cf3
@siddharthkp
typo
52a3608
@siddharthkp
I not H
5309eb1
@siddharthkp
change example from labels to assignees
8930146
@siddharthkp
1. make it work....
96f4ca0
@siddharthkp
move implementation details from story → component
4393e0c
@siddharthkp
absorb EmptyMessage into SelectPanel.Message
d42096e
@siddharthkp
absorb WarningMessage into SelectPanel.Message
cda8096
@siddharthkp
absorb ErrorMessage into SelectPanel.Message
310fefe
@siddharthkp
stricter types for empty
336b42e
@siddharthkp
clean up lint errors
8d15989
@siddharthkp
Merge branch 'main' into drafts-selectpanel-validation
8cc84c6
@siddharthkp
tiny cleanup for bug
24127c1
@siddharthkp
clean up message types real good!
db5359f
@siddharthkp
child can be null
68af462
@siddharthkp
types: first round
bd44d73
@siddharthkp
types: round 2 - cleanup
030416b
@siddharthkp
types: round 3 more cleanup
20cc878
@siddharthkp
types: 4 clean up stories ignores
abfa75c
@siddharthkp
types: 5 clean up stories
bac97c2
@siddharthkp
Merge branch 'main' into drafts-selectpanel-types
3f0b47a
@siddharthkp
SelectPanel.Loading no longer exists
0afa927
@siddharthkp
Revert "SelectPanel.Loading no longer exists"
540e2d3 
This reverts commit 0afa927.
@siddharthkp
use TextInputProps for SelectPanel.SearchInput
c5ac721
@siddharthkp
sync internal and props.open with state
4da0ec1
@siddharthkp @joshblack
use ?? instead of ||
4acebcd 
Co-authored-by: Josh Black <joshblack@github.com>
@siddharthkp
copy changes over from branch:drafts-selectpanel-dialog
b004f32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7e15545

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.23 KB (0%)
dist/browser.umd.js 104.75 KB (0%)

siddharthkp added a commit that referenced this pull request Dec 5, 2023
@siddharthkp
copy changes from #4018
f3eddf6
@siddharthkp
Copy link
Member Author

@siddharthkp siddharthkp closed this Dec 5, 2023
@siddharthkp siddharthkp deleted the drafts-selectpanel-with-dialog branch December 7, 2023 13:31
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2023
@siddharthkp
SelectPanel2: Use html dialog (#4020)
c2a53a0 
* copy changes from #4018

* remove undefined values

* add autofocus

* sync esc with internalClose

* move focus logic to only work once

* change tooltip direction to stay within input

* note for self

* add temporary example for question

* Revert "add temporary example for question"

This reverts commit 19bc492.

* move comment closer to code

* nudge user towards actions when clicking outside

* oops

* Create eleven-lizards-draw.md

* change animation duration to 350ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@siddharthkp