Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm outlineButton from storybook #3883

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

lukasoppermann
Copy link
Contributor

Changelog

  • removed outline variant for Button from storybook

Rollout strategy

No change to components.

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Oct 31, 2023
@lukasoppermann lukasoppermann requested review from a team and joshblack October 31, 2023 08:51
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: e6c0fc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (0%)
dist/browser.umd.js 104.13 KB (0%)

@lukasoppermann lukasoppermann temporarily deployed to github-pages October 31, 2023 08:58 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3883 October 31, 2023 08:58 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! 👍

For timeline, what are we hoping to do with the outline variant? I'm assuming we want to deprecate/remove it and start moving folks towards another option? (Like invisible?)

@lukasoppermann
Copy link
Contributor Author

For timeline, what are we hoping to do with the outline variant? I'm assuming we want to deprecate/remove it and start moving folks towards another option? (Like invisible?)

Yes. @maximedegreve is working on getting it out of github.

I think the alternative is just to use a normal secondary version.

@lukasoppermann lukasoppermann added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 33d302a Nov 1, 2023
29 checks passed
@lukasoppermann lukasoppermann deleted the rm-outlineButton-storybook branch November 1, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants