-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm outlineButton from storybook #3883
Conversation
|
size-limit report 📦
|
22206d2
to
e6c0fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! 👍
For timeline, what are we hoping to do with the outline variant? I'm assuming we want to deprecate/remove it and start moving folks towards another option? (Like invisible?)
Yes. @maximedegreve is working on getting it out of github. I think the alternative is just to use a normal |
Changelog
outline
variant forButton
from storybookRollout strategy
No change to components.
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.