Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip v2: Update tooltip draft id and add to the primer.style/react navigation #3810

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Oct 11, 2023

Changelog

New

Changed

The component id of tooltip and tooltip v2 are the same. Tooltip v2 component details end up overriding the tooltip v1's. You can see the generated/components.json data has one tooltip (id is tooltip but it has draft tooltip's data.) This is wrong. I updated the draft tooltips data to be unique.

Removed

Rollout strategy

No changeset requires.

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

⚠️ No Changeset found

Latest commit: 8b0c3fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Oct 11, 2023
@broccolinisoup broccolinisoup changed the title update tooltip draft id and add to the nav Tooltip v2: Update tooltip draft id and add to the primer.style/react navigation Oct 11, 2023
@broccolinisoup broccolinisoup changed the title Tooltip v2: Update tooltip draft id and add to the primer.style/react navigation Tooltip v2: Update tooltip draft id and add to the primer.style/react navigation Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.75 KB (0%)
dist/browser.umd.js 105.33 KB (0%)

@broccolinisoup broccolinisoup marked this pull request as ready for review October 11, 2023 05:45
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 11, 2023 05:48 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3810 October 11, 2023 05:48 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages October 11, 2023 05:56 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3810 October 11, 2023 05:57 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 44dd8ec Oct 12, 2023
31 checks passed
@broccolinisoup broccolinisoup deleted the bs/update-tooltip-id branch October 12, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants