Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: get all public exports from package entrypoints #3733

Merged
merged 9 commits into from
Oct 12, 2023
Merged

test: get all public exports from package entrypoints #3733

merged 9 commits into from
Oct 12, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 11, 2023 •
edited
Loading

Update our exports test to include support for additional export members, like types.

Changelog

New

Changed

  • Update exports.test.ts with a new technique for getting exports from a module
  • Update snapshots for exports for:
    • @primer/react
    • @primer/react/experimental
    • @primer/react/drafts
    • @primer/react/deprecated

Removed

Rollout strategy

None

Testing & Reviewing

Verify that the generated snapshot captures export information accurately

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a8823c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.7 KB (0%)
dist/browser.umd.js 105.27 KB (0%)

@joshblack joshblack temporarily deployed to github-pages September 11, 2023 16:25 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3733 September 11, 2023 16:25 Inactive
@joshblack joshblack marked this pull request as ready for review September 28, 2023 16:36
@joshblack joshblack changed the title test: add experiment for getting all public exports test: get all public exports from package entrypoints Sep 28, 2023
@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 28, 2023
@joshblack joshblack temporarily deployed to github-pages September 28, 2023 16:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3733 September 28, 2023 16:41 Inactive
siddharthkp
siddharthkp reviewed Oct 2, 2023
View reviewed changes
script/get-exports.mjs Outdated
@@ -0,0 +1,453 @@
import {existsSync} from 'node:fs'
Copy link
Member

@siddharthkp siddharthkp Oct 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is super cool!

I'm a bit confused about where would we like to call this script from? from within ./script/build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharthkp whoops! This was my test script, removed in the latest commit since it's in the test file itself 👍

@github-actions github-actions bot temporarily deployed to storybook-preview-3733 October 5, 2023 15:15 Inactive
@joshblack joshblack temporarily deployed to github-pages October 5, 2023 15:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3733 October 5, 2023 15:17 Inactive
@joshblack
Copy link
Member Author

bump @siddharthkp @broccolinisoup when you get a sec 👀

siddharthkp
siddharthkp approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Took me a while to understand, but now I get it 😇

@joshblack joshblack added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 30b7dee Oct 12, 2023
31 checks passed
@joshblack joshblack deleted the experiment/add-export-detection branch October 12, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @siddharthkp