NavList: Fix when subNav opens automatically and shows current indicator #3611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: If the second item is selected, NavList does not open the subNav automatically and does not show current indicator at the subNav level when folded
before-navlist.mov
After: If the second item is selected, NavList does open subNav automatically and shows the current indicator at the subNav level
after-navlist.mov
Implementation detail
While we did check for
aria-current !== false
, we did this for the first element witharia-current
, which could be the one witharia-current=false
:)Changing the selector to exclude false value takes care of this.