Update ActionList checkbox styles #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0556808 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…r/react into action-list-checkbox-style
size-limit report 📦
|
langermank
commented
Aug 9, 2023
| placeContent: 'center', | ||
| width: 'var(--base-size-16, 16px)', | ||
| backgroundColor: selected ? 'accent.fg' : 'canvas.default', | ||
| transition: selected |
There was a problem hiding this comment.
@mperrotti I could use some eyes on the transitions. I know something is off about it but I can't quite find it, and I think everything is backwards here compared to a checked state since I'm using selected.. but fresh eyes on it will probably reveal the issue.
…r/react into action-list-checkbox-style
…r/react into action-list-checkbox-style
I feel like this should be a |
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This was referenced Aug 28, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox styles for ActionList should match our Checkbox component. And that's what I did.
This is a bit of a copy/paste from Checkbox, but it doesn't totally make sense to share styles with a semantic
input. Also, this isn't accounting for an upcoming change to makeActionMenuuse checkmarks for single and multi. This is mostly needed forSelectPanel.Question for reviewers
Is this a minor or breaking change?
Closes https://github.com/github/primer/issues/2487
Screenshots
| Before | After |
| 
|
|
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.