Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading prop for Button and IconButton #3582

Merged
merged 84 commits into from
Mar 21, 2024
Merged

Add loading prop for Button and IconButton #3582

merged 84 commits into from
Mar 21, 2024

Commits on Aug 1, 2023

  1. draft loading state

    @langermank
    langermank committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a1c03e2 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @langermank
    langermank committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    cfd0944 View commit details
    Browse the repository at this point in the history

  3. add story to trigger loading

    @langermank
    langermank committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9408220 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'main' into button-loading-state

    @langermank
    langermank authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    18d7954 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1cc0465 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. merge

    @langermank
    langermank committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a9a7771 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5c901d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Merge branch 'main' into button-loading-state

    @langermank
    langermank authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fae28dd View commit details
    Browse the repository at this point in the history

  2. icon button

    @langermank
    langermank committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    72a0247 View commit details
    Browse the repository at this point in the history

  3. Create lazy-jobs-pump.md

    @langermank
    langermank authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    71b747d View commit details
    Browse the repository at this point in the history

  4. add prop for loading message

    @langermank
    langermank committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    556aff9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'button-loading-state' of https://github.com/primer/react … 

    …into button-loading-state
    @langermank
    langermank committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    03ce69f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'button-loading-state' of github.com:primer/react into b… 

    …utton-loading-state
    @mperrotti
    mperrotti committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f7b316d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. handle no visuals loading state

    @langermank
    langermank committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6f98511 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'button-loading-state' of github.com:primer/react into b… 

    …utton-loading-state
    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5080989 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f3e6d07 View commit details
    Browse the repository at this point in the history

  3. updates snapshots after merging from main

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ee21a63 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5956393 View commit details
    Browse the repository at this point in the history

  5. uses unique ID for loading messages, preserves aria-describedby passe… 

    …d to button, rms aria-busy
    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9687486 View commit details
    Browse the repository at this point in the history

  6. adds Storybook examples for btn loading error message

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2fc7c4d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7f981b0 View commit details
    Browse the repository at this point in the history

  8. reverts unintentional default link underlining

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    49d8853 View commit details
    Browse the repository at this point in the history

  9. changes loadingMessage to loadingAnnouncement

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3aa7225 View commit details
    Browse the repository at this point in the history

  10. updates draft Button component with loading prop

    @mperrotti
    mperrotti committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7f7f326 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. updates legacy button counter behavior when loading

    @mperrotti
    mperrotti committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    73b59c7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fc15b72 View commit details
    Browse the repository at this point in the history

  3. Revert "updates draft Button component with loading prop" 

    This reverts commit 7f7f326.
    @mperrotti
    mperrotti committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c277957 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d556bc9 View commit details
    Browse the repository at this point in the history

  2. moves error behavior stories to 'Examples' section

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ccaa4ae View commit details
    Browse the repository at this point in the history

  3. screenreader fixes

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    30fb01d View commit details
    Browse the repository at this point in the history

  4. adds and updates unit tests

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    22c7c65 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    787bfaa View commit details
    Browse the repository at this point in the history

  6. re-updates snapshots after using correct VisuallyHidden

    @mperrotti
    mperrotti committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6dcf5b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    09a3199 View commit details
    Browse the repository at this point in the history

  2. documents loading props

    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    0e276de View commit details
    Browse the repository at this point in the history

  3. adds VRTs, updates loading feature stories

    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e8fcd21 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3eee19a View commit details
    Browse the repository at this point in the history

  5. simplifies inner visual/spinner rendering logic

    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e63e61c View commit details
    Browse the repository at this point in the history

  6. removes example stories (we can put them back when Flash supports foc… 

    …using its heading)
    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8a901da View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    39f2d4e View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    24abbcd View commit details
    Browse the repository at this point in the history

  2. excludes loading buttons from axe contrast check

    @mperrotti
    mperrotti committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ffdff03 View commit details
    Browse the repository at this point in the history

  3. fixes visual regression: button counter vertical alignment

    @mperrotti
    mperrotti committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9d133a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    e069e04 View commit details
    Browse the repository at this point in the history

  2. prevents double spinners when leading and trailing visuals are passed

    @mperrotti
    mperrotti committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    611eea0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. test(e2e): update story ids

    @joshblack
    joshblack committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7cf14ca View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @joshblack @github-actions
    joshblack authored and github-actions[bot] committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1a4a08d View commit details
    Browse the repository at this point in the history

  3. test(e2e): disable animations in screenshots

    @joshblack
    joshblack committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a091125 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'button-loading-state' of github.com:primer/react into b… 

    …utton-loading-state
    @joshblack
    joshblack committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e4a6f41 View commit details
    Browse the repository at this point in the history

  5. test(vrt): update snapshots

    @joshblack @github-actions
    joshblack authored and github-actions[bot] committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c9a0743 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. preserves rest state styles when button is loading

    @mperrotti
    mperrotti committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4d9128e View commit details
    Browse the repository at this point in the history

  2. adds story for success and error announcement

    @mperrotti
    mperrotti committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3c38084 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9408882 View commit details
    Browse the repository at this point in the history

  4. test(vrt): update snapshots

    @langermank @github-actions
    langermank authored and github-actions[bot] committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ceb5ba2 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c7501e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ad02496 View commit details
    Browse the repository at this point in the history

  3. fixes ButtonGroup regression

    @mperrotti
    mperrotti committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    db094c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fe2dcee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e300738 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fb6d639 View commit details
    Browse the repository at this point in the history

  4. delete broken snapshots

    @langermank
    langermank committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    0911586 View commit details
    Browse the repository at this point in the history

  5. also targets anchor tags in ButtonGroup styles

    @mperrotti
    mperrotti committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1416fcb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e245fe9 View commit details
    Browse the repository at this point in the history

  7. add conditional wrapper

    @langermank
    langermank committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5e8877e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'button-loading-state' of https://github.com/primer/react … 

    …into button-loading-state
    @langermank
    langermank committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f2ccc8e View commit details
    Browse the repository at this point in the history

  9. fix group

    @langermank
    langermank committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f301ffe View commit details
    Browse the repository at this point in the history

  10. test(vrt): update snapshots

    @langermank @github-actions
    langermank authored and github-actions[bot] committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e7a25ef View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into button-loading-state

    @langermank
    langermank authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    71de776 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. lint

    @mperrotti
    mperrotti committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2e5ed47 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'button-loading-state' of github.com:primer/react into b… 

    …utton-loading-state
    @mperrotti
    mperrotti committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6c425f9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    01e07a1 View commit details
    Browse the repository at this point in the history

  4. fixes unit tests, updates snapshots

    @mperrotti
    mperrotti committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    20d81f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Update src/Button/Button.docs.json 

    Co-authored-by: Pavithra Kodmad <pksjce@github.com>
    @mperrotti @pksjce
    mperrotti and pksjce authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b3cdce6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into button-loading-state

    @mperrotti
    mperrotti authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c38523c View commit details
    Browse the repository at this point in the history

  3. fixes 'block' layout for loading buttons

    @mperrotti
    mperrotti committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    9ad96f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7e5bc66 View commit details
    Browse the repository at this point in the history

  2. uses new internal Status component for loading announcement

    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f781434 View commit details
    Browse the repository at this point in the history

  3. updates Tooltip V2 tests to account for loading messageID in button's… 

    … aria-describedby
    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6f9f6ed View commit details
    Browse the repository at this point in the history

  4. fixes BoxProps type import to new preferred syntax

    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8809ba5 View commit details
    Browse the repository at this point in the history

  5. appease the linter

    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9649e4e View commit details
    Browse the repository at this point in the history

  6. rms ConditionalWrapper

    @mperrotti
    mperrotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    87fa84b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. revert back to using ConditionalWrapper with aria-describedby

    @mperrotti
    mperrotti committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5acdcb9 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'main' of github.com:primer/react into button-loading-state

    @mperrotti
    mperrotti committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c0e2a3d View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @mperrotti @github-actions
    mperrotti authored and github-actions[bot] committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a7b114b View commit details
    Browse the repository at this point in the history