Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @react-aria/ssr to ^3.5.0 #3561

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 25, 2023

Addresses the first half of: #3554

When using components like FormControl which use useSSRSafeId under the hood, users may run into a hydration error when running in strict mode. This was due to the double-render behavior of StrictMode which would cause the ids to mismatch between the server, where things would only render once, and client.

This was addressed upstream by: adobe/react-spectrum#3980 and should be available starting in 3.5.0. This PR updates our dependency from ^3.1.0 to ^3.5.0 so that the minimum version of @react-aria/ssr includes this fix.

Note
In newer versions of this dependency, SSRProvider will warn as it is no longer needed in React 18

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 80c11e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 102.42 KB (0%)
dist/browser.umd.js 103 KB (0%)

@joshblack joshblack temporarily deployed to github-pages July 25, 2023 17:51 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3561 July 25, 2023 17:51 Inactive
@joshblack joshblack marked this pull request as ready for review July 25, 2023 18:06
@joshblack joshblack requested review from a team, langermank and siddharthkp July 25, 2023 18:06
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants