Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionList.Item width for full variant #3516

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Jul 13, 2023

Describe your changes here.

🤖 Generated by Copilot at 6512a3c

This pull request fixes the width issue of the ActionList.Item component in the @primer/react package. It adds a conditional width style based on the listVariant prop and updates the changeset file for a patch release.

Screenshots

Before After
screenshot-fb2AVLWx-000579@2x screenshot-lhsQOHpJ-000580@2x

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@danielguillan danielguillan requested review from a team and josepmartins July 13, 2023 12:19
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 024cdb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.92 KB (+0.02% 🔺)
dist/browser.umd.js 102.44 KB (+0.01% 🔺)

@danielguillan danielguillan force-pushed the danielguillan/fix-action-list-item-width-full branch from 6512a3c to 35bfc6a Compare July 13, 2023 12:25
@github-actions github-actions bot temporarily deployed to storybook-preview-3516 July 13, 2023 12:26 Inactive
@danielguillan danielguillan temporarily deployed to github-pages July 13, 2023 12:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3516 July 13, 2023 12:32 Inactive
@danielguillan danielguillan force-pushed the danielguillan/fix-action-list-item-width-full branch from 35bfc6a to 957886a Compare July 13, 2023 13:48
@danielguillan danielguillan temporarily deployed to github-pages July 13, 2023 13:54 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3516 July 13, 2023 13:54 Inactive
Co-authored-by: Mike Perrotti <mperrotti@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants