Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: ActionList item label weight and spacing if description exists #3490

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Bug fix: ActionList item label weight and spacing if description exists #3490

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f969a3a
fix item with description
langermank Jul 6, 2023
36b5967
Create kind-eggs-cheer.md
langermank Jul 6, 2023
9c3b809
Merge branch 'main' into fix-actionlist-item-bold
langermank Jul 6, 2023
46edde9
Merge branch 'main' into fix-actionlist-item-bold
langermank Jul 6, 2023
45d7b83
test(vrt): update snapshots
langermank Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-eggs-cheer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Bug fix: ActionList item label weight and spacing if description exists
4 changes: 3 additions & 1 deletion src/ActionList/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
id={labelId}
sx={{
flexGrow: slots.description && slots.description.props.variant !== 'block' ? 0 : 1,
fontWeight: slots.description && slots.description.props.variant !== 'block' ? 'bold' : 'normal',
fontWeight: slots.description ? 'bold' : 'normal',
marginBlockEnd:
slots.description && slots.description.props.variant !== 'inline' ? '4px' : undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be the token space-1 than 4px?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone let me know what the syntax is meant to look like to access the spacing token here? I couldn't figure it out, gave up and used px 😛

Copy link
Member

@siddharthkp siddharthkp Jul 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- slots.description && slots.description.props.variant !== 'inline' ? '4px' : undefined,
+ slots.description && slots.description.props.variant !== 'inline' ? 1 : undefined,

unlessssssss, styled-system doesn't understand logical properties like marginBlockEnd, only marginRight because the last release was in 2019 (open issue).

We could figure out how to add support for logical properties in primer/react or we could add '4px' for now and move on. I say 4px and move on. (only for primer, look the other way @maraisr 😛)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIGH haha okay, thanks @siddharthkp!

}}
>
{childrenWithoutSlots}
Expand Down